Ian Maxon has posted comments on this change. Change subject: [WIP][NO ISSUE] Make IOManager more configurable ......................................................................
Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3133/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: PS2, Line 92: INTEGER > Assuming this must be > 0, POSITIVE_INTEGER Done PS2, Line 93: INTEGER > Assuming this must be > 0, POSITIVE_INTEGER Done PS2, Line 585: getIOParallelism > Consider Io -vs- IO I did it this way because we have other parameters that already have it formatted as IO (IODevices & so) https://asterix-gerrit.ics.uci.edu/#/c/3133/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java: PS2, Line 70: private final int ioParallelism; : private final int queueLen; > do we need these? nope, thought it might be useful if we wanted to query it but it's redundant from the config now that i think about it more https://asterix-gerrit.ics.uci.edu/#/c/3133/2/hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreehelper/src/main/java/org/apache/hyracks/examples/btree/helper/RuntimeContext.java File hyracks-fullstack/hyracks/hyracks-examples/btree-example/btreehelper/src/main/java/org/apache/hyracks/examples/btree/helper/RuntimeContext.java: PS2, Line 63: 10 > should this be the configured queue capacity? this is just a test harness, here we don't use NCConfig at all so we can't get the config. normally in NCAppRuntimeContext we do set it to the configured value -- To view, visit https://asterix-gerrit.ics.uci.edu/3133 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c8ad11c2b8b983ef4bf7cf78c2f068accddfff4 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
