Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1714: Eliminate dependency on org.json ......................................................................
Patch Set 16: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1392/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ClusterNodeDetailsAPIServlet.java: Line 80: ObjectMapper om = new ObjectMapper(); > Can we remove this one? Is there a relationship between nodes created by th I actually just forgot to remove this, in previous patches I made an new ObjectMapper reach time I needed an ObjectNode within a method, but that felt suboptimal here where it's needed across many methods. There is shared state but it's not a problem here as all the methods in the class want the same thing more or less. https://asterix-gerrit.ics.uci.edu/#/c/1392/16/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java: Line 979: // <library-directory> > Revert/fix indentation? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1392 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9c5400fd134ae75d43385255af7794e968b1c7e Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
