abdullah alamoudi has posted comments on this change. Change subject: Change the API for writing and reading metadata pages ......................................................................
Patch Set 9: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1396/9/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java: Line 393: fileProperties.initialize(filePath, fileSize, replicaId, false, -1L, false); > Indeed. Done Line 393: fileProperties.initialize(filePath, fileSize, replicaId, false, -1L, false); > Might as well use the named variable here too. Done https://asterix-gerrit.ics.uci.edu/#/c/1396/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java: Line 746: } else { > Per our quick chat, it would be good to add a TODO here or something so who Done Line 746: } else { > Maybe file an issue and add the link to the issue to the TODO as well? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1396 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadad522ab5568677aa816c74fc1d63acad505380 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
