Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][FUN] Modify array functions to allow comparing complex ......................................................................
Patch Set 3: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3313/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarDistinctAggregateDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarDistinctAggregateDescriptor.java: Line 44: @Override > minor. can we rename this method to createDescriptorFactory() to better des Done https://asterix-gerrit.ics.uci.edu/#/c/3313/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArrayAddRemoveEval.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArrayAddRemoveEval.java: Line 223 > The evaluator code seems not the best place to have a descriptor factory im Done https://asterix-gerrit.ics.uci.edu/#/c/3313/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayConcatDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayConcatDescriptor.java: Line 56: public static final IFunctionDescriptorFactory FACTORY = new IFunctionDescriptorFactory() { > Why are we not using AbstractArrayAddRemoveEval.createFactory() here? Seems I only refactored the non-code gen functions. code-gen functions broke when I refactored them. It looks like it does not tolerate changing the "FACTORY" variable in any way. https://asterix-gerrit.ics.uci.edu/#/c/3313/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRemoveDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRemoveDescriptor.java: Line 132: // for the list item, it's either the item type if input list is determined to be a list or ANY if not. > Let's address this SonarQube comment. Can we make this method static? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3313 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I416989cf902eda38224a3b00340e478fc4e3a60c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
