Michael Blow has submitted this change and it was merged.
Change subject: Merge commit '153b2ce970' from 'stabilization-f69489'
......................................................................
Merge commit '153b2ce970' from 'stabilization-f69489'
Change-Id: I5b0d2756d839b0bc2e7c59723306921e698a7630
---
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java
3 files changed, 12 insertions(+), 17 deletions(-)
Approvals:
Michael Blow: Verified; Verified
Murtadha Hubail: Looks good to me, approved
Objections:
Anon. E. Moose #1000171: Violations found
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 1acb190..07da3f9 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -4820,14 +4820,14 @@
</compilation-unit>
</test-case>
<test-case FilePath="group-by">
-<<<<<<< HEAD (072800 [NO ISSUE][FUN] Make Dump_Index Function Return An
Array of )
<compilation-unit name="sugar-08-negative">
<output-dir compare="Text">core-01</output-dir>
<expected-error>ASX1103: Illegal use of identifier: x</expected-error>
-=======
+ </compilation-unit>
+ </test-case>
+ <test-case FilePath="group-by">
<compilation-unit name="sugar-09">
<output-dir compare="Text">sugar-09</output-dir>
->>>>>>> BRANCH (153b2c [NO ISSUE][STO] Ensure Invalid Merged Components Are
Deleted)
</compilation-unit>
</test-case>
<test-case FilePath="group-by">
diff --git
a/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java
b/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java
index 08fd421..3fc5683 100644
---
a/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java
+++
b/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java
@@ -36,11 +36,8 @@
import org.apache.asterix.lang.common.expression.GbyVariableExpressionPair;
import org.apache.asterix.lang.common.expression.QuantifiedExpression;
import org.apache.asterix.lang.common.expression.VariableExpr;
-<<<<<<< HEAD (072800 [NO ISSUE][FUN] Make Dump_Index Function Return An
Array of )
import org.apache.asterix.lang.common.struct.Identifier;
-=======
import org.apache.asterix.lang.common.struct.QuantifiedPair;
->>>>>>> BRANCH (153b2c [NO ISSUE][STO] Ensure Invalid Merged Components Are
Deleted)
import org.apache.asterix.lang.common.struct.VarIdentifier;
import org.apache.asterix.lang.sqlpp.clause.AbstractBinaryCorrelateClause;
import org.apache.asterix.lang.sqlpp.clause.FromClause;
@@ -197,7 +194,15 @@
return bindingVars;
}
-<<<<<<< HEAD (072800 [NO ISSUE][FUN] Make Dump_Index Function Return An
Array of )
+ public static List<VariableExpr> getBindingVariables(QuantifiedExpression
qe) {
+ List<QuantifiedPair> quantifiedList = qe.getQuantifiedList();
+ List<VariableExpr> bindingVars = new
ArrayList<>(quantifiedList.size());
+ for (QuantifiedPair qp : quantifiedList) {
+ bindingVars.add(qp.getVarExpr());
+ }
+ return bindingVars;
+ }
+
public static Map<Expression, Identifier>
createFieldVariableMap(List<Pair<Expression, Identifier>> fieldList) {
Map<Expression, Identifier> fieldVars = new HashMap<>();
for (Pair<Expression, Identifier> p : fieldList) {
@@ -211,14 +216,5 @@
VariableExpr newVarExpr = new VariableExpr(var);
newVarExpr.setSourceLocation(varExpr.getSourceLocation());
outFieldList.add(new Pair<>(newVarExpr,
toUserDefinedVariableName(var)));
-=======
- public static List<VariableExpr> getBindingVariables(QuantifiedExpression
qe) {
- List<QuantifiedPair> quantifiedList = qe.getQuantifiedList();
- List<VariableExpr> bindingVars = new
ArrayList<>(quantifiedList.size());
- for (QuantifiedPair qp : quantifiedList) {
- bindingVars.add(qp.getVarExpr());
- }
- return bindingVars;
->>>>>>> BRANCH (153b2c [NO ISSUE][STO] Ensure Invalid Merged Components Are
Deleted)
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java
index 88a6962..ac390e3 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexBulkLoadOperatorNodePushable.java
@@ -33,7 +33,6 @@
import
org.apache.hyracks.storage.am.common.tuples.PermutingFrameTupleReference;
import org.apache.hyracks.storage.common.IIndex;
import org.apache.hyracks.storage.common.IIndexBulkLoader;
-import org.apache.hyracks.util.annotations.CriticalPath;
public class IndexBulkLoadOperatorNodePushable extends
AbstractUnaryInputUnaryOutputOperatorNodePushable {
protected final IHyracksTaskContext ctx;
--
To view, visit https://asterix-gerrit.ics.uci.edu/3329
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b0d2756d839b0bc2e7c59723306921e698a7630
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
