Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Modifty range map function of parallel sort ......................................................................
Patch Set 3: Code-Review+2 (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3333/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: Line 745: // TODO: shouldn't indexSearchOp execution mode be set to that of the input? the default is UNPARTITIONED Yes, let's do that. https://asterix-gerrit.ics.uci.edu/#/c/3333/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java: Line 1767: addPrivateFunction(LOCAL_SAMPLING, ABinaryTypeComputer.INSTANCE, true); Minor. This should be INSTANCE_NULLABLE because it can produce system_null. https://asterix-gerrit.ics.uci.edu/#/c/3333/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeMapAggregateDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeMapAggregateDescriptor.java: Line 183: List<byte[]> oneSample = new ArrayList<>(numOrderByFields); minor. at some point may be we should see if we can eliminate these array allocations. https://asterix-gerrit.ics.uci.edu/#/c/3333/3/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: Line 787: private void createAggregateFunction(IOptimizationContext context, List<LogicalVariable> localResultVariables, Minor. At some point we should give this method a more specific name. https://asterix-gerrit.ics.uci.edu/#/c/3333/3/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/ForwardOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/ForwardOperatorDescriptor.java: Line 178: ByteArrayPointable pointable = new ByteArrayPointable(); Minor. We could avoid creating instances of ByteArrayPointable, ByteArrayInputStream and DataInputStream here for each frame. We have org.apache.hyracks.data.std.util.ByteArrayAccessibleInputStream that is resettable. -- To view, visit https://asterix-gerrit.ics.uci.edu/3333 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7edbb10906cc4464210af87a5b1630ba3aecbde0 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
