Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3322 )
Change subject: [ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Resolution" rule ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Looks good - found 1 typo in there docs. Please forward the +2 if you decide to fix the typo before submission. https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md: https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_3_resolution.md@261 PS4, Line 261: expresion expression https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java: https://asterix-gerrit.ics.uci.edu/#/c/3322/4/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/Sql92AggregateFunctionVisitor.java@169 PS4, Line 169: // TODO: move to VariableCheckAndRewriteVisitor File a task for this? -- To view, visit https://asterix-gerrit.ics.uci.edu/3322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b9f70a1671378f5216ec4e30416d4d67c3df089 Gerrit-Change-Number: 3322 Gerrit-PatchSet: 4 Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Fri, 12 Apr 2019 02:24:50 +0000 Gerrit-HasComments: Yes
