Xikui Wang has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3270 )
Change subject: [NO ISSUE][FUN] Fix type inference and casting in UDFs ...................................................................... Patch Set 9: Code-Review+2 (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java: https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/ExternalFunction.java@45 PS7, Line 45: protected final IExternalFunction externalFunctionInstance; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java: https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java@41 PS7, Line 41: public class ExternalFunctionCompilerUtil { > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java@142 PS7, Line 142: } > MAJOR SonarQube violation: save for future uses. https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java@146 PS7, Line 146: private static IFunctionInfo getUnnestFunctionInfo(MetadataTransactionContext txnCtx, Function function) { > MAJOR SonarQube violation: same as above. https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/ExternalFunctionCompilerUtil.java@150 PS7, Line 150: private static IFunctionInfo getStatefulFunctionInfo(MetadataTransactionContext txnCtx, Function function) { > MAJOR SonarQube violation: same as above. https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/ExternalFunctionInfo.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/ExternalFunctionInfo.java: https://asterix-gerrit.ics.uci.edu/#/c/3270/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/ExternalFunctionInfo.java@27 PS7, Line 27: public class ExternalFunctionInfo extends FunctionInfo implements IExternalFunctionInfo { > MAJOR SonarQube violation: dk whether this should be overridden or not. The comparison logic is not changed -- To view, visit https://asterix-gerrit.ics.uci.edu/3270 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40506fcca3cd8f14bbd6412359683433256c4c1f Gerrit-Change-Number: 3270 Gerrit-PatchSet: 9 Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2019 05:50:32 +0000 Gerrit-HasComments: Yes
