Dmitry Lychagin has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3153 )

Change subject: [ASTERIXDB-2450][DOC] make docs match implementation
......................................................................

[ASTERIXDB-2450][DOC] make docs match implementation

details:
- change site documentation to match function implementation
- add example for ms_from_day_time_duration

Change-Id: Iacd4cd18b232df7845c80bdb6136f28185193905
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3153
Sonar-Qube: Jenkins <[email protected]>
Integration-Tests: Jenkins <[email protected]>
Reviewed-by: Preston Carman <[email protected]>
Reviewed-by: Dmitry Lychagin <[email protected]>
Tested-by: Dmitry Lychagin <[email protected]>
---
M asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md
1 file changed, 8 insertions(+), 6 deletions(-)

Approvals:
  Jenkins: No violations found; Verified
  Preston Carman: Looks good to me, but someone else must approve
  Dmitry Lychagin: Looks good to me, approved; Verified

Objections:
  Anon. E. Moose (1000171): Violations found



diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md
index cee47ba..dd07124 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/7_temporal.md
@@ -157,28 +157,30 @@

         year_month_duration("P1Y")

-### months_from_year_month_duration/milliseconds_from_day_time_duration ###
+### months_from_year_month_duration/ms_from_day_time_duration ###
 * Syntax:

-        
months_from_year_month_duration/milliseconds_from_day_time_duration(duration_value)
+        
months_from_year_month_duration/ms_from_day_time_duration(duration_value)

 * Extracts the number of months or the number of milliseconds from the 
`duration` subtype.
 * Arguments:
     * `duration_value` : a `duration` of the correct subtype.
 * Return Value:
-    * an `bigint` representing the number or months/milliseconds,
+    * a `bigint` representing the number of months/milliseconds,
     * `missing` if the argument is a `missing` value,
     * `null` if the argument is a `null` value,
     * any other non-duration input value will cause a type error.

 * Example:

-        
months_from_year_month_duration(get_year_month_duration(duration("P5Y7MT50M")));
-
+        {
+            "months": 
months_from_year_month_duration(get_year_month_duration(duration("P5Y7MT50M"))),
+            "milliseconds": 
ms_from_day_time_duration(get_day_time_duration(duration("P5Y7MT50M")))
+        };

 * The expected result is:

-        67
+        {"months": 67, "milliseconds": 3000000}


 ### duration_from_months/duration_from_ms ###

--
To view, visit https://asterix-gerrit.ics.uci.edu/3153
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacd4cd18b232df7845c80bdb6136f28185193905
Gerrit-Change-Number: 3153
Gerrit-PatchSet: 4
Gerrit-Owner: Stephen Ermshar <[email protected]>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>

Reply via email to