Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3043 )
Change subject: [NO ISSUE][FUN] Code generator alternative ...................................................................... Patch Set 12: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/runtime/evaluators/common/EditDistanceCheckEvaluator.java File asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/runtime/evaluators/common/EditDistanceCheckEvaluator.java: https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-fuzzyjoin/src/main/java/org/apache/asterix/runtime/evaluators/common/EditDistanceCheckEvaluator.java@73 PS12, Line 73: // MISSING and NULL checks i'd like to remove these from all these classes- i think it's clear without the comments... this should be easy enough to do with a sed one-liner hopefully... https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayIntersectDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayIntersectDescriptor.java: https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayIntersectDescriptor.java@231 PS12, Line 231: // If it's not missing, then it's null, but don't return until all arguments are checked for missing > MAJOR SonarQube violation: +1 https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java: https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@215 PS12, Line 215: // Pointable2 : switch (checkMissingOrNull(pointable2)) { : case MISSING: : setMissing(result); : return true; : case NULL: : isMeetNull = true; : break; : } : would prefer to move the null check for pointable outside of checkMissingOrNull, and make the argment @NotNull. I'm afraid that nesting this might make it more apt for the JIT to not handle this as efficiently as possible... same applies for pointable3 and 4 below. https://asterix-gerrit.ics.uci.edu/#/c/3043/12/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java@264 PS12, Line 264: pointable != null see above comment -- To view, visit https://asterix-gerrit.ics.uci.edu/3043 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icca2e2128c4b0f2bfd8675655cf5296cbbaeba88 Gerrit-Change-Number: 3043 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 14:28:28 +0000 Gerrit-HasComments: Yes
