Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3133 )
Change subject: [NO ISSUE] Make IOManager more configurable ...................................................................... Patch Set 7: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3133/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: https://asterix-gerrit.ics.uci.edu/#/c/3133/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java@589 PS7, Line 589: Len > Size seems less confusing- Len sounds like current count of items in the qu Done https://asterix-gerrit.ics.uci.edu/#/c/3133/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java: https://asterix-gerrit.ics.uci.edu/#/c/3133/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java@76 PS7, Line 76: queueLen > queueSize Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3133 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c8ad11c2b8b983ef4bf7cf78c2f068accddfff4 Gerrit-Change-Number: 3133 Gerrit-PatchSet: 7 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Wed, 17 Apr 2019 23:43:08 +0000 Gerrit-HasComments: Yes
