Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/2453 )
Change subject: [ASTERIXDB-2310][STO]Enforce Key Uniquness using PKIndex ...................................................................... Patch Set 22: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java: https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/BTreeResourceFactoryProvider.java@111 PS22, Line 111: index.isPrimaryIndex() || index.isPrimaryKeyIndex() I don't think this is a good idea. We have many places in the system where we do checks based on the lILSMIndex#isPrimaryIndex. Considering a primary key index as a primary index can easily lead to many issues. You already encountered one of those in CheckpointManager and had to use instanceof to get around it. We need to do this in a better way. https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java: https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java@66 PS22, Line 66: indexForUniquessCheck make this local variable https://asterix-gerrit.ics.uci.edu/#/c/2453/22/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryInsertOperatorNodePushable.java@129 PS22, Line 129: forceUpsert If you have multiple concurrent writers on the same dataset, what prevents the case that a memory component is never flushed because all operations are forced? -- To view, visit https://asterix-gerrit.ics.uci.edu/2453 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a52bb75ee5b14521972999df2f45ba62adc5af1 Gerrit-Change-Number: 2453 Gerrit-PatchSet: 22 Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2019 03:07:13 +0000 Gerrit-HasComments: Yes
