Ali Alsuliman has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3261 )
Change subject: [ASTERIXDB-2551][*DB] Use Ordered Property in range merge POperator - user model changes: no - storage format changes: no - interface changes: no details: - Create the IPartitioningProperty using the orderedPartitionedProperty instead of creating th ...................................................................... [ASTERIXDB-2551][*DB] Use Ordered Property in range merge POperator - user model changes: no - storage format changes: no - interface changes: no details: - Create the IPartitioningProperty using the orderedPartitionedProperty instead of creating the list to be used in an unorderedPartitionProperty. Change-Id: I044e2219fff7564864f68fa0df849d1102b4bb20 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3261 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> --- M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionMergeExchangePOperator.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Jenkins: Verified; No violations found; Verified Ali Alsuliman: Looks good to me, approved Objections: Anon. E. Moose (1000171): Violations found diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionMergeExchangePOperator.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionMergeExchangePOperator.java index b015193..ee43f3f 100644 --- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionMergeExchangePOperator.java +++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/RangePartitionMergeExchangePOperator.java @@ -23,7 +23,6 @@ import java.util.List; import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException; -import org.apache.hyracks.algebricks.common.utils.ListSet; import org.apache.hyracks.algebricks.common.utils.Pair; import org.apache.hyracks.algebricks.core.algebra.base.IHyracksJobBuilder.TargetConstraint; import org.apache.hyracks.algebricks.core.algebra.base.ILogicalOperator; @@ -44,7 +43,7 @@ import org.apache.hyracks.algebricks.core.algebra.properties.OrderColumn; import org.apache.hyracks.algebricks.core.algebra.properties.PhysicalRequirements; import org.apache.hyracks.algebricks.core.algebra.properties.StructuralPropertiesVector; -import org.apache.hyracks.algebricks.core.algebra.properties.UnorderedPartitionedProperty; +import org.apache.hyracks.algebricks.core.algebra.properties.OrderedPartitionedProperty; import org.apache.hyracks.algebricks.core.jobgen.impl.JobGenContext; import org.apache.hyracks.algebricks.data.IBinaryComparatorFactoryProvider; import org.apache.hyracks.algebricks.data.INormalizedKeyComputerFactoryProvider; @@ -85,11 +84,7 @@ @Override public void computeDeliveredProperties(ILogicalOperator op, IOptimizationContext context) { - List<LogicalVariable> varList = new ArrayList<LogicalVariable>(); - for (OrderColumn oc : partitioningFields) { - varList.add(oc.getColumn()); - } - IPartitioningProperty p = new UnorderedPartitionedProperty(new ListSet<LogicalVariable>(varList), domain); + IPartitioningProperty p = new OrderedPartitionedProperty(partitioningFields, domain); AbstractLogicalOperator op2 = (AbstractLogicalOperator) op.getInputs().get(0).getValue(); List<ILocalStructuralProperty> op2Locals = op2.getDeliveredPhysicalProperties().getLocalProperties(); List<ILocalStructuralProperty> locals = new ArrayList<ILocalStructuralProperty>(); -- To view, visit https://asterix-gerrit.ics.uci.edu/3261 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I044e2219fff7564864f68fa0df849d1102b4bb20 Gerrit-Change-Number: 3261 Gerrit-PatchSet: 3 Gerrit-Owner: Stephen Ermshar <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]>
