Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3361 )
Change subject: [NO ISSUE] Introduce MissingNullInOutFunction annotation ...................................................................... Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3361/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ExceptionIT.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ExceptionIT.java: https://asterix-gerrit.ics.uci.edu/#/c/3361/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ExceptionIT.java@78 PS1, Line 78: System.out define a logger in this class and use it instead of System.out https://asterix-gerrit.ics.uci.edu/#/c/3361/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NullMissingTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NullMissingTest.java: https://asterix-gerrit.ics.uci.edu/#/c/3361/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NullMissingTest.java@89 PS1, Line 89: System.out define a logger in this class and use it instead of System.out https://asterix-gerrit.ics.uci.edu/#/c/3361/1/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/MissingNullInOutFunction.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/MissingNullInOutFunction.java: https://asterix-gerrit.ics.uci.edu/#/c/3361/1/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/annotations/MissingNullInOutFunction.java@19 PS1, Line 19: org.apache.hyracks.util.annotations Move this to org.apache.asterix.common.annotations package. Hyracks shouldn't know about something called function. -- To view, visit https://asterix-gerrit.ics.uci.edu/3361 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I253373ae4c8e23d9f5ed38f5fbbdefe9680e04b4 Gerrit-Change-Number: 3361 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Thu, 25 Apr 2019 09:17:28 +0000 Gerrit-HasComments: Yes
