Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 )
Change subject: [WIP] Introduce data generator data source functions ...................................................................... Patch Set 6: (17 comments) https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java: https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@35 PS3, Line 35: > will Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@71 PS3, Line 71: > I think (hope) that we don't need to reset a new CharArrayRecord. Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@103 PS3, Line 103: > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@137 PS3, Line 137: > We should avoid appending the comma instead of copying the whole record her Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSReader.java@141 PS3, Line 141: > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java: https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@38 PS3, Line 38: > according to the specification of the TPC Benchmark DS Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@38 PS3, Line 38: : : > remove Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@42 PS3, Line 42: > takes Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@42 PS3, Line 42: > data generator Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@43 PS3, Line 43: > a valid table name Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@44 PS3, Line 44: > the desired scaling factor Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@62 PS3, Line 62: > tableNameType? Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@62 PS3, Line 62: > extract variable tableNameArgumentValue Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@63 PS3, Line 63: > extract variable scalingFactorArgumentValue Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@63 PS3, Line 63: > scalingFactorType? Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/TPCDSRewriter.java@75 PS3, Line 75: > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java: https://asterix-gerrit.ics.uci.edu/#/c/3360/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/MetadataBuiltinFunctions.java@62 PS3, Line 62: // TPC-DS data generation function > this is metadata for builtin functions - it belongs here Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3360 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb6bd6f697628395c70008e6f730bc5ca403da5e Gerrit-Change-Number: 3360 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Sun, 28 Apr 2019 05:51:26 +0000 Gerrit-HasComments: Yes
