Michael Blow has posted comments on this change. Change subject: Cleanup AsterixDB Dependencies ......................................................................
Patch Set 12: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1421/12/asterixdb/asterix-algebra/pom.xml File asterixdb/asterix-algebra/pom.xml: Line 181: <groupId>org.apache.hyracks</groupId> > Ok, I feel bad as I write this, but if we ordered grouped them by Hyracks a le sigh- yeah, it would be nice if the plugin would do that when it suggests them too :-) I have a solution which will organize our POMs, including sorting the dependencies- I would propose submitting that in a follow-on change. https://asterix-gerrit.ics.uci.edu/#/c/1421/12/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: Line 333: <version>1.2.17</version> > Do we only have log4j in this module? Done https://asterix-gerrit.ics.uci.edu/#/c/1421/12/asterixdb/asterix-metadata/pom.xml File asterixdb/asterix-metadata/pom.xml: Line 89: <version>0.2.18-SNAPSHOT</version> > Why do we have explicit hyracks versions here? Missed a sweep (the plugin when declaring missing dependencies emits them this way- I fix them up). Done. Line 104: <version>0.8.9-SNAPSHOT</version> > ... and AsterixDB versions? Done Line 137: <version>4.12</version> Done. https://asterix-gerrit.ics.uci.edu/#/c/1421/12/asterixdb/asterix-yarn/pom.xml File asterixdb/asterix-yarn/pom.xml: Line 417: <version>1.2.9</version> > log4j Done Line 427: <version>2.2.0</version> > Is this the same hadoop-version we use in the root pom? I will move this to dep mgmt, and reference the property. It's easier to identify these when they're redefining something already present in dep mgmt, as IDEA annotates them. -- To view, visit https://asterix-gerrit.ics.uci.edu/1421 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc9d4db57b2138931baa3ef51ea569c45b79a2f Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
