Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3353 )
Change subject: [ASTERIXDB-2552][RT] Implement micro external sort for subplans ...................................................................... Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3353/1/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/sort/MicroSortRuntimeFactory.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/sort/MicroSortRuntimeFactory.java: https://asterix-gerrit.ics.uci.edu/#/c/3353/1/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/sort/MicroSortRuntimeFactory.java@94 PS1, Line 94: public void close() throws HyracksDataException { > Where do we close the "writer"? It's changed now with the refactoring. It's closed here explicitly. https://asterix-gerrit.ics.uci.edu/#/c/3353/1/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/sort/MicroSortRuntimeFactory.java@127 PS1, Line 127: } > should we call super.fail() to fail the writer? It's changed now. The writer is failed here in the wrappingWriter. -- To view, visit https://asterix-gerrit.ics.uci.edu/3353 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I930849d644c60d461d2869c9773b85e49b46fbdb Gerrit-Change-Number: 3353 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Tue, 30 Apr 2019 06:04:46 +0000 Gerrit-HasComments: Yes
