Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3378 )
Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context ...................................................................... Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java: https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java@206 PS2, Line 206: IOException, AsterixException Just stick with "Exception" like most other methods in this class? https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java: https://asterix-gerrit.ics.uci.edu/#/c/3378/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java@195 PS2, Line 195: IOException, AsterixException Just stick with "Exception" like most other methods in this class? -- To view, visit https://asterix-gerrit.ics.uci.edu/3378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb4dc6d8dbc00c8a701fddb1a3205d1070078cb4 Gerrit-Change-Number: 3378 Gerrit-PatchSet: 2 Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Anon. E. Moose <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Sat, 04 May 2019 00:29:51 +0000 Gerrit-HasComments: Yes
