Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3381 )
Change subject: [NO ISSUE][FUN] Simplify error message + cleanup ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3381/1/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: https://asterix-gerrit.ics.uci.edu/#/c/3381/1/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties@78 PS1, Line 78: %1$s: \"%2$s\" is not a TPC-DS table name Minor: Would it be a clearer message if we make it "is not a valid TPC-DS table name"? I don't think it's a big deal though. -- To view, visit https://asterix-gerrit.ics.uci.edu/3381 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bbcb63f266685befc80de957687249191345063 Gerrit-Change-Number: 3381 Gerrit-PatchSet: 1 Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Sat, 04 May 2019 04:40:03 +0000 Gerrit-HasComments: Yes
