Michael Blow has posted comments on this change. Change subject: WIP - Modularize feed adaptors ......................................................................
Patch Set 1: (1 comment) Looks pretty good to me, a minor request on the API, and please consider the SQ comments. For testing, probably the twitter tests should be moved to a new test suite which runs from the villain module. I think you can just add a new test in your module which is a copy of AqlExecutionTest, and move the twitter related tests into the testsuite.xml within that module. Hopefully that makes sense. https://asterix-gerrit.ics.uci.edu/#/c/1430/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReaderFactory.java: Line 36: public String[] getRecordReaderNames(); Would prefer this to be something immutable, such as Set<String>, where the implementations return an unmodifiable set. -- To view, visit https://asterix-gerrit.ics.uci.edu/1430 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f95255f5493a813ee1f875b63a62e74bc47602 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
