Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ......................................................................
Patch Set 33: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1076/33/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 296: prepareJoin = "join" + AQLPLUS; Let's define this as final static String constant like the following final static String AQLPLUS_INNER_JOIN = "join"; Line 299: prepareJoin = "loj" + AQLPLUS; Let's define this as final static String constant like the following final static String AQLPLUS_LEFTOUTER_JOIN = "loj"; Line 302: throw new IllegalStateException(); Let's follow the error handling scheme here: https://cwiki.apache.org/confluence/display/ASTERIXDB/Exception+Handling -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 33 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <lwhaym...@yahoo.com> Gerrit-Reviewer: Chen Li <che...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Wenhai Li <lwhaym...@yahoo.com> Gerrit-HasComments: Yes
