Michael Blow has posted comments on this change.

Change subject: Subset hive-exec, make twitter4j a provided dep.
......................................................................


Patch Set 7:

(4 comments)

Should we repackage these if we're going to compile them?  +1 on all the SQ WS 
complaints.

https://asterix-gerrit.ics.uci.edu/#/c/1427/7/asterixdb/asterix-external-data-tools/pom.xml
File asterixdb/asterix-external-data-tools/pom.xml:

Line 1: <!-- 
ws


Line 36:       <plugins>
looks like wrong indent here


Line 54:       <version>0.13.0</version>
Can we move all/some of these versions to dependencyManagement?


https://asterix-gerrit.ics.uci.edu/#/c/1427/7/asterixdb/asterix-external-data/pom.xml
File asterixdb/asterix-external-data/pom.xml:

Line 406:       <version>2.5</version>
Version from dep mgmt?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1427
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee4276f540ec8552181bfb452882654b5faa17df
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to