Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3242 )
Change subject: [NO ISSUE] Additional constructor for TaggedValuePointable ...................................................................... Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3242/5/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java: https://asterix-gerrit.ics.uci.edu/#/c/3242/5/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java@39 PS5, Line 39: value.set(bytes, start + 1, length - 1); > Yes, we would need to adjust the pointers when setting the pointable. given the assumption that the value passed to "set" should be tagged, we should keep this as is. -- To view, visit https://asterix-gerrit.ics.uci.edu/3242 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cad369ecb2f7cafd901f11e757272dce7e1e6b5 Gerrit-Change-Number: 3242 Gerrit-PatchSet: 5 Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Comment-Date: Tue, 14 May 2019 00:40:47 +0000 Gerrit-HasComments: Yes
