Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3356 )
Change subject: [NO ISSUE][DOC] Refresh and update text-example ...................................................................... Patch Set 3: (7 comments) > For nicer rendering on GitHub, it might be useful to use markdown > for the READMEs. Formatted them in markdown, at least the code snippets. Not sure what else could be formatted like that. https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textclient/src/main/conf/README File hyracks-fullstack/hyracks/hyracks-examples/text-example/textclient/src/main/conf/README: https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textclient/src/main/conf/README@1 PS3, Line 1: This package holds a very simple Hyracks client program that counts the words in a supplied text file. A prerequisite > should we include ASF license header? Would sort of make the readme obtuse. https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textclient/src/main/conf/README@4 PS3, Line 4: In the > in the what? Done https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/README File hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/README: https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/README@1 PS3, Line 1: This example sets up a very basic Hyracks cluster to be used for counting words in a file with the textclient example. > should we include ASF header? I don't think so. It's a README. https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/README@4 PS3, Line 4: conf/nc.conf > is this right? (nc.conf) Done https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/README@6 PS3, Line 6: T > ...t Done https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/README@8 PS3, Line 8: conf/nc.conf > is this right? (nc.conf) Done https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/text.conf File hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/text.conf: https://asterix-gerrit.ics.uci.edu/#/c/3356/3/hyracks-fullstack/hyracks/hyracks-examples/text-example/textserver/src/main/conf/text.conf@25 PS3, Line 25: app.class = org.apache.hyracks.control.cc.BaseCCApplication > redundant Sure, but it's for illustration. -- To view, visit https://asterix-gerrit.ics.uci.edu/3356 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie756e790994cd6d8dad69cce1bb728923cc0398c Gerrit-Change-Number: 3356 Gerrit-PatchSet: 3 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Thu, 16 May 2019 18:35:13 +0000 Gerrit-HasComments: Yes
