Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3399 )
Change subject: [ASTERIXDB-2289][COMP] Fix field access with CASE ...................................................................... Patch Set 4: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3399/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java: https://asterix-gerrit.ics.uci.edu/#/c/3399/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java@202 PS4, Line 202: HashSet<LogicalVariable> usedInAccess = new HashSet<>(); minor. use interface in variable declaration (Set<LogicalVariable> usedInAccess = new HashSet<>()) here and below -- To view, visit https://asterix-gerrit.ics.uci.edu/3399 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I911e4e9018c15e8f226e46fa610d222eb2301fcd Gerrit-Change-Number: 3399 Gerrit-PatchSet: 4 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Thu, 16 May 2019 23:12:04 +0000 Gerrit-HasComments: Yes
