Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3406 )
Change subject: [ASTERIXDB-2458][COMP] Fix InjectTypeCastForFunctionArgumentsRule ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3406/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/TypeResolverUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/TypeResolverUtil.java: https://asterix-gerrit.ics.uci.edu/#/c/3406/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/common/TypeResolverUtil.java@98 PS2, Line 98: public static boolean castable(ATypeTag tag) { This method's name can be confusing. Primitive types are in general castable to other primitive types, but this method implies that they're not. I'd remove this method and would just use ATypeTag.isDerivedType() here and in InjectTypeCastForFunctionArgumentsRule. Both callers get actual type (from union) before calling this method, so isDerivedType() should work fine. -- To view, visit https://asterix-gerrit.ics.uci.edu/3406 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fee234d883b59319e4ec4df58d61ecd498373fd Gerrit-Change-Number: 3406 Gerrit-PatchSet: 2 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Fri, 24 May 2019 18:42:44 +0000 Gerrit-HasComments: Yes
