Murtadha Hubail has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3408 )
Change subject: [NO ISSUE][OTH] Skip Result Metadata Updates on No Result ...................................................................... [NO ISSUE][OTH] Skip Result Metadata Updates on No Result - user model changes: no - storage format changes: no - interface changes: no Details: - Do not attempt to update the result metadata when a job has no result to avoid NPE. Change-Id: I1ccae6003048f45344a5b7843a25c61d6a7bd366 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3408 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Hussain Towaileb <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins: Verified; No violations found; Verified Hussain Towaileb: Looks good to me, approved Objections: Anon. E. Moose (1000171): Violations found diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java index 30814c6..ecf92a0 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/JobResultCallback.java @@ -25,6 +25,7 @@ import org.apache.hyracks.api.job.JobId; import org.apache.hyracks.api.result.IJobResultCallback; import org.apache.hyracks.api.result.ResultJobRecord; +import org.apache.hyracks.api.result.ResultSetMetaData; import org.apache.hyracks.control.cc.ClusterControllerService; import org.apache.hyracks.control.cc.job.IJobManager; import org.apache.hyracks.control.cc.job.JobRun; @@ -53,7 +54,11 @@ } private void updateResultMetadata(JobId jobId, ResultJobRecord resultJobRecord) { - final ResultMetadata metadata = (ResultMetadata) resultJobRecord.getResultSetMetaData().getMetadata(); + final ResultSetMetaData resultSetMetaData = resultJobRecord.getResultSetMetaData(); + if (resultSetMetaData == null) { + return; + } + final ResultMetadata metadata = (ResultMetadata) resultSetMetaData.getMetadata(); metadata.setJobDuration(resultJobRecord.getJobDuration()); metadata.setProcessedObjects(getJobProccssedObjects(jobId)); } -- To view, visit https://asterix-gerrit.ics.uci.edu/3408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1ccae6003048f45344a5b7843a25c61d6a7bd366 Gerrit-Change-Number: 3408 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
