Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/3410 to look at the new patch set (#3). Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter ...................................................................... [NO ISSUE][OTH] Introduce ResponsePrinter - user model changes: no - storage format changes: no - interface changes: yes Details: - Introduce ResponsePrinter that is responsible for printing the returned response from query service. - Make ResponsePrinter responsible for adding separators between fields in the returned response. - Introduce IResponseFieldPrinter and encapsulate each response field in its own printer. - Introduce ICodedMessage and use it for any object that has code<->message (e.g errors and warnings). Change-Id: I797e6615a72c886391fed26281fc648b38fa748f --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutorFactory.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionOutput.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/AbstractQueryApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionError.java R asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ExecutionWarning.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponseMertics.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResponsePrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultHandle.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/AbstractCodedMessagePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ClientContextIdPrinter.java C asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ErrorsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ExplainOnlyResultsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/MetricsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/NcResultPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ParseOnlyResultPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/PlansPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/RequestIdPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ResultHandlePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/ResultsPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/SignaturePrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/StatusPrinter.java A asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/TypePrinter.java C asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/fields/WarningsPrinter.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/app/result/ResultPrinterTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/active/ActiveStatsTest.java C asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/ICodedMessage.java C asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IResponseFieldPrinter.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IResponsePrinter.java 41 files changed, 1,356 insertions(+), 420 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/10/3410/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3410 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I797e6615a72c886391fed26281fc648b38fa748f Gerrit-Change-Number: 3410 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>