Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3409 )
Change subject: [NO ISSUE][FUN] Bitwise - use unknowable instead of nullable ...................................................................... Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3409/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java: https://asterix-gerrit.ics.uci.edu/#/c/3409/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/BitMultipleValuesTypeComputer.java@67 PS1, Line 67: boolean isReturnUnknowable = false; > why this change though? Do you ever return missing for invalid arguments? W I mean that the case of argument being ANY is supposed to be handled by AbstractResultTypeComputer (see TypeComputeUtils.resolveResultType()). If it's not happening there in your case then we need to investigate why. -- To view, visit https://asterix-gerrit.ics.uci.edu/3409 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93e002531812ac26fe70e573db1467ea52b9920a Gerrit-Change-Number: 3409 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 01:14:22 +0000 Gerrit-HasComments: Yes
