Murtadha Hubail has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3413 )
Change subject: [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config ...................................................................... [NO ISSUE][CONF] Mark KeyStore Pass As Hidden Config - user model changes: no - storage format changes: no - interface changes: no Details: - Mark KeyStore pass as a hidden config to avoid displaying the password on APIs that use the hidden flag to certain config. Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3413 Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins: Verified; ; Verified Anon. E. Moose (1000171): Ali Alsuliman: Looks good to me, approved Objections: Jenkins: Violations found diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java index a38ee65..4f35aca 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java @@ -211,6 +211,11 @@ public String usageDefaultOverride(IApplicationConfig accessor, Function<IOption, String> optionPrinter) { return defaultValueDescription; } + + @Override + public boolean hidden() { + return this == KEY_STORE_PASSWORD; + } } private List<String> appArgs = new ArrayList<>(); diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java index dd92798..e947d7a 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java @@ -247,6 +247,10 @@ return defaultValueDescription; } + @Override + public boolean hidden() { + return this == KEY_STORE_PASSWORD; + } } public String getReplicationPublicAddress() { -- To view, visit https://asterix-gerrit.ics.uci.edu/3413 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1c27c3b229ca7d8dd44717c21cd096f0090a7278 Gerrit-Change-Number: 3413 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
