Taewoo Kim has posted comments on this change. Change subject: Change the compiliation related Exception ......................................................................
Patch Set 5: (5 comments) @Till: Thanks for your comments. I have addressed all. https://asterix-gerrit.ics.uci.edu/#/c/1437/5//COMMIT_MSG Commit Message: Line 7: Change the compiliation related Exception > s/compiliation/compilation/ Done https://asterix-gerrit.ics.uci.edu/#/c/1437/5/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml: Line 3441: <expected-error>org.apache.asterix.common.exceptions.CompilationException: Cannot create index testIdx2 , enforced index testIdx1 on field "[value]" is already defined with type "[int32]"</expected-error> > Should we just remove the exception class from the error message? Done Line 3447: <expected-error>org.apache.asterix.common.exceptions.CompilationException: Cannot create index testIdx2 , enforced index testIdx1 on field "[value]" is already defined with type "[int64]"</expected-error> > Should we just remove the exception class from the error message? Done https://asterix-gerrit.ics.uci.edu/#/c/1437/5/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/CompilationException.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/CompilationException.java: Line 38: // Intermediate: don't use this and provide an error code. This exists for the current exceptions. > Mark these as deprecated? Done https://asterix-gerrit.ics.uci.edu/#/c/1437/5/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/FunctionUtil.java: Line 27: import org.apache.asterix.common.exceptions.CompilationException; > One too many? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1437 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ff2bc3b70ad78e53a19ad94d98d17a4469ca4e1 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
