Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3415 )
Change subject: [NO ISSUE][CONF] Make Starting Hyracks Console Configurable ...................................................................... Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3415/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: https://asterix-gerrit.ics.uci.edu/#/c/3415/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java@214 PS1, Line 214: ccConfig.isStartWebConsole() new flags are problematic for stabilization branch- can we reserve a negative port as disabled? https://asterix-gerrit.ics.uci.edu/#/c/3415/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java: https://asterix-gerrit.ics.uci.edu/#/c/3415/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java@78 PS1, Line 78: START_WEB_CONSOLE(BOOLEAN, true); new flags are problematic for binary compatibility reasons in stabilization branch, can we reserve a negative port for disabled? -- To view, visit https://asterix-gerrit.ics.uci.edu/3415 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-MessageType: comment Gerrit-Change-Id: If0050b298431b150690959b6d35db69182777ff6 Gerrit-Change-Number: 3415 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2019 11:56:58 +0000 Gerrit-HasComments: Yes
