Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3427 )
Change subject: [ASTERIXDB-2574][COMP] Fix min/max functions ...................................................................... Patch Set 1: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeHelper.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeHelper.java: https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeHelper.java@75 PS1, Line 75: return ((ARecordType) actualType).getFieldNames().length == 0; && ARecordType.isOpen() https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/TypeHelper.java@80 PS1, Line 80: default: add case for: ANY: return true https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java: https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java@118 PS1, Line 118: compareAndUpdate(cmp, inputVal, outputVal, typeTag); cast to the wider type as before, then do comparison https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java@132 PS1, Line 132: systemNullFinish.perform(); isLocal then call local else call global. no need for method references https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/SqlMinMaxAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/SqlMinMaxAggregateFunction.java: https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/SqlMinMaxAggregateFunction.java@41 PS1, Line 41: private final boolean isIgnoringNull; enum or rename this field to avoid confusion https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/DescriptorFactoryUtil.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/DescriptorFactoryUtil.java: https://asterix-gerrit.ics.uci.edu/#/c/3427/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/DescriptorFactoryUtil.java@33 PS1, Line 33: public static IFunctionDescriptorFactory createFactory(Supplier<IFunctionDescriptor> descriptorSupplier) { move to abstract aggregate dynamic descriptor -- To view, visit https://asterix-gerrit.ics.uci.edu/3427 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1231cfe558099d167bae0b2fa7fc4879b756baf0 Gerrit-Change-Number: 3427 Gerrit-PatchSet: 1 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2019 19:24:15 +0000 Gerrit-HasComments: Yes
