Hussain Towaileb has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/3438
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs()
......................................................................
[NO ISSUE][FUN] round() remove unnecessary Math.abs()
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Removed unnecessary Math.abs().
Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
---
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/38/3438/1
diff --git
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
index c06fd35..11aa620 100644
---
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
+++
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
@@ -172,7 +172,7 @@
if (roundingDigit >= 0) {
// Multiplier based on round digit
- double multiplier = Math.pow(10, Math.abs(roundingDigit));
+ double multiplier = Math.pow(10, roundingDigit);
switch (valueTypeTag) {
// For zero and positive digit rounding, no need to do
anything for integers
@@ -209,8 +209,8 @@
}
// Left of decimal (negative roundingDigit value)
else {
- // Multiplier based on round digit
- double multiplier = Math.pow(10, Math.abs(roundingDigit));
+ // Multiplier based on round digit (convert to positive digit)
+ double multiplier = Math.pow(10, -roundingDigit);
switch (valueTypeTag) {
case TINYINT:
--
To view, visit https://asterix-gerrit.ics.uci.edu/3438
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4
Gerrit-Change-Number: 3438
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb <[email protected]>
