Hussain Towaileb has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3438 )
Change subject: [NO ISSUE][FUN] round() remove unnecessary Math.abs() ...................................................................... [NO ISSUE][FUN] round() remove unnecessary Math.abs() - user model changes: no - storage format changes: no - interface changes: no Details: - Removed unnecessary Math.abs(). Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3438 Contrib: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Hussain Towaileb <[email protected]> Reviewed-by: Dmitry Lychagin <[email protected]> --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins: Verified; ; Verified Hussain Towaileb: Looks good to me, but someone else must approve Dmitry Lychagin: Looks good to me, approved Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java index c06fd35..11aa620 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java @@ -172,7 +172,7 @@ if (roundingDigit >= 0) { // Multiplier based on round digit - double multiplier = Math.pow(10, Math.abs(roundingDigit)); + double multiplier = Math.pow(10, roundingDigit); switch (valueTypeTag) { // For zero and positive digit rounding, no need to do anything for integers @@ -209,8 +209,8 @@ } // Left of decimal (negative roundingDigit value) else { - // Multiplier based on round digit - double multiplier = Math.pow(10, Math.abs(roundingDigit)); + // Multiplier based on round digit (convert to positive digit) + double multiplier = Math.pow(10, -roundingDigit); switch (valueTypeTag) { case TINYINT: -- To view, visit https://asterix-gerrit.ics.uci.edu/3438 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib7409faa9b3b172124f5e283c668027d52ae63d4 Gerrit-Change-Number: 3438 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]>
