Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/2936 )
Change subject: [NO ISSUE][DASH] Plan Format, Flat Nested Objects on Table ...................................................................... Patch Set 19: Code-Review+1 (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/LICENSE File asterixdb/LICENSE: https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/LICENSE@324 PS15, Line 324: : are available under The Apache License, Version 2.0: : --- : Apache License : Version 2.0, January 2004 : http://www.apache.org/licenses/ > see comment in template (duplicate asterix-dashboard/src/main/resources/) Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl File asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl: https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@59 PS15, Line 59: > this is not used, it's overridden in macro use below Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@60 PS15, Line 60: <@license licenseName="The Apache License, Version 2.0" component="AsterixDB Dashboard fonts" : location="${asterixAppLocation!}" filePrefix="${asterixDashboardResourcesP > it would be cleaner I think to define these as parameters to the license ma Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@63 PS15, Line 63: "assets/fonts/material-icons/Mat > is this correct? (I wonder if we should capitalize all or none, because I Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/asterix-dashboard/src/main/licenses/dashboard-license.ftl@65 PS15, Line 65: -Regular.ttf", : "assets/fonts/mat > remove Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl File asterixdb/src/main/licenses/templates/source_licenses.ftl: https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl@142 PS15, Line 142: Dashboard > sp Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl@143 PS15, Line 143: : Embedded fonts in asterix-dashboard are from material-design-icons (https://github > it would be cleaner I think to define these as parameters to the license ma Done https://asterix-gerrit.ics.uci.edu/#/c/2936/15/asterixdb/src/main/licenses/templates/source_licenses.ftl@149 PS15, Line 149: assets/fonts/materia > this results in a duplicate prefix, as the license macro already prepends ' Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2936 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a27a5576ae21b6fda440bfc281d25e62638515c Gerrit-Change-Number: 2936 Gerrit-PatchSet: 19 Gerrit-Owner: Emilio Jose Coronado Lopez <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2019 01:37:15 +0000 Gerrit-HasComments: Yes
