Taewoo Kim has posted comments on this change.

Change subject: Applied the multiway fuzzyjoin based on the prefix-based join 
and the selectFuzzyJoin testCases.
......................................................................


Patch Set 39:

For "Since the newly introduced rules inside FuzzyJoinRuleCollection is 
triggered before its following ABC rule collections (remember ABC F ABC?). You 
know, we configured CondPushDownAndJoinInferenceRuleCollection as noDfs to 
avoid the dead loop of the iterative RemoveUnusedVars/AggsRule after 
PushSelectIntoJoinRule and its related rules. I guess the variable has been 
substituted by FuzzyCollections before the second round of ABC, which results 
in this inconsistencies. But after we check that difference, we find they are 
isomorphic, i.e., the only difference aims at the variable number $101 -> $102, 
does it matter?", 

Understood. Again, the concern here is that fuzzy-join framework interferes 
with non-fuzzy join queries. To prevent this happening, if the fuzzy join rule 
is not fired in F collection, none of rules in F collection will be fired. The 
change will be reviewed and merged soon: 
https://asterix-gerrit.ics.uci.edu/#/c/1432/

At your side, you don't need to do anything. Let's see what happens.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 39
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <[email protected]>
Gerrit-Reviewer: Chen Li <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Wenhai Li <[email protected]>
Gerrit-HasComments: No

Reply via email to