Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3446 )
Change subject: [NO ISSUE][REPL] Wait For Dataset IO Before Replica Sync ...................................................................... Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3446/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/#/c/3446/1/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java@138 PS1, Line 138: on-going > ongoing Done https://asterix-gerrit.ics.uci.edu/#/c/3446/1/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/sync/ReplicaSynchronizer.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/sync/ReplicaSynchronizer.java: https://asterix-gerrit.ics.uci.edu/#/c/3446/1/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/sync/ReplicaSynchronizer.java@84 PS1, Line 84: appCtx.getDatasetLifecycleManager().waitForIO(replStrategy); > what prevents new IO from starting after ensuring that any ongoing operatio replica sychronization is done when the cluster isn't active, so no new operations will be performed that might trigger IO operations. This change waits for ongoing IO before the initial sync, then waits for any merge operations that might happen due to the flush triggered in line 60 before completing the sync. -- To view, visit https://asterix-gerrit.ics.uci.edu/3446 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-MessageType: comment Gerrit-Change-Id: I01ed5c9379cf7ae249faeef624d5226ea699cf22 Gerrit-Change-Number: 3446 Gerrit-PatchSet: 1 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Sun, 16 Jun 2019 23:16:17 +0000 Gerrit-HasComments: Yes
