Murtadha Hubail has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3445 )
Change subject: [NO ISSUE][MTD] Fix Reading Dataset Compression From Dataset Record ...................................................................... [NO ISSUE][MTD] Fix Reading Dataset Compression From Dataset Record - user model changes: no - storage format changes: no - interface changes: no Details: - Fix reading the dataset compression scheme by reading its value from the compression record rather than the dataset record. Change-Id: I3bdb1f64143fed43dc9eb37cf8a2fadbfd37dfde Reviewed-on: https://asterix-gerrit.ics.uci.edu/3445 Contrib: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> Reviewed-by: Wail Alkowaileet <[email protected]> --- M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins: Verified; ; Verified Murtadha Hubail: Looks good to me, but someone else must approve Wail Alkowaileet: Looks good to me, approved Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java index 27978ab..7f8b9bf6 100644 --- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java +++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/DatasetTupleTranslator.java @@ -282,7 +282,8 @@ final ARecordType compressionType = (ARecordType) datasetType.getFieldTypes()[compressionIndex]; final int schemeIndex = compressionType .getFieldIndex(MetadataRecordTypes.DATASET_ARECORD_DATASET_COMPRESSION_SCHEME_FIELD_NAME); - return ((AString) datasetRecord.getValueByPos(schemeIndex)).getStringValue(); + final ARecord compressionRecord = (ARecord) datasetRecord.getValueByPos(compressionIndex); + return ((AString) compressionRecord.getValueByPos(schemeIndex)).getStringValue(); } return CompressionManager.NONE; } -- To view, visit https://asterix-gerrit.ics.uci.edu/3445 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3bdb1f64143fed43dc9eb37cf8a2fadbfd37dfde Gerrit-Change-Number: 3445 Gerrit-PatchSet: 2 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
