Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3285 )
Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O ...................................................................... Patch Set 9: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java: https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java@99 PS9, Line 99: The maximum disk write rate (bytes/s) for each dataset what does 0 (the default) mean; we should probably indicate that here https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java@101 PS9, Line 101: for before? https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/#/c/3285/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java@359 PS9, Line 359: populateRateLimiter can we return the rate limiter from this method, to avoid the extra lookup? https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java: https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java@65 PS9, Line 65: F f https://asterix-gerrit.ics.uci.edu/#/c/3285/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/FIFOLocalWriter.java@65 PS9, Line 65: A a -- To view, visit https://asterix-gerrit.ics.uci.edu/3285 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f618dc7c186623e860239b4d97640fe3528e75b Gerrit-Change-Number: 3285 Gerrit-PatchSet: 9 Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 17:27:14 +0000 Gerrit-HasComments: Yes
