Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3451 )
Change subject: [ASTERIXDB-2598][RT] Add Support For Runtime Warnings ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3451/3/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml: https://asterix-gerrit.ics.uci.edu/#/c/3451/3/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml@12361 PS3, Line 12361: <expected-warn>ASX0003: Type incompatibility: function min/max gets incompatible input values: bigint and string</expected-warn> I wonder whether we can be more precise here and specify a set of warnings for each query instead of a union of all expected warnings for all queries in the testcase. May be <expected-warn> <warning>... </warning> .... </expected-warn> <expected-warn> ... </expected-warn> -- To view, visit https://asterix-gerrit.ics.uci.edu/3451 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52fa5b807799487d62e67a8861068e1547aa629a Gerrit-Change-Number: 3451 Gerrit-PatchSet: 3 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2019 18:50:00 +0000 Gerrit-HasComments: Yes
