Yingyi Bu has posted comments on this change. Change subject: Fix async result delivery ......................................................................
Patch Set 28: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/1394/28/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 2617: GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, add e to be the last parameter of the log method? https://asterix-gerrit.ics.uci.edu/#/c/1394/28/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml: Line 28: <expected-error>HYR0002: Error in processing tuple 0</expected-error> Should or shouldn't we have error code? It looks that we don't have error code in other test cases. https://asterix-gerrit.ics.uci.edu/#/c/1394/28/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java File asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java: Line 821: "no handle for " + reqType + " test " + testFile.toString()); Use Assert.assert(...)? Line 843: throw new IllegalStateException( Use Assert.assert(...)? Line 1091: variableCtx.put("number", 1); move main(...) to be a unit test? -- a test for TestExecutor..? or remove it? https://asterix-gerrit.ics.uci.edu/#/c/1394/28/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/InjectFailureTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/InjectFailureTypeComputer.java: Line 34: if (argIndex == 1 && type.getTypeTag() != ATypeTag.BOOLEAN) { == 0? https://asterix-gerrit.ics.uci.edu/#/c/1394/28/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SleepDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SleepDescriptor.java: Line 68: LOGGER.log(Level.INFO, ctx.getTaskAttemptId() + " sleeping for " + time + " ms"); check log level before the log call? Line 73: LOGGER.log(Level.INFO, ctx.getTaskAttemptId() + " done sleeping for " + time + " ms"); check log level? https://asterix-gerrit.ics.uci.edu/#/c/1394/28/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetJobRecord.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/DatasetJobRecord.java: Line 86: ResultSetId rsId = entry.getKey(); Rename the method to be "toString"? If both ResultSetId and ResultSetMetaData implement toString(), there seems no need to manually loop over the map. Line 106: throw new AssertionError("inconsistent metadata for result set " + rsId); Use error code and exception for that? https://asterix-gerrit.ics.uci.edu/#/c/1394/28/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java: Line 76: LOGGER.info(getClass().getSimpleName() + " notified of new job " + jobId); Check log level before calling info(...)? https://asterix-gerrit.ics.uci.edu/#/c/1394/28/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java: Line 46: Logger logger) { What's the motivation of using the logger in DatasetPartitionManager? It will print wrong class name? Line 62: logger.severe("Result cleaner thread interrupted, shutting down."); put e as a parameter to the severe call? -- To view, visit https://asterix-gerrit.ics.uci.edu/1394 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafba65d9c7bd8643c42e5126c8d89164ae328908 Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
