Yingyi Bu has posted comments on this change. Change subject: AQLPlus Refactoring 1: add a new rule controller ......................................................................
Patch Set 11: Code-Review+1 (2 comments) Seems there are some typos in comments? https://asterix-gerrit.ics.uci.edu/#/c/1432/11/hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java File hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java: Line 93: // Case 3: a mixture of returning true/false. true, false, false? typo? Line 95: // Iteration2: R1 false, R2 false, R3 false true, true, false? -- To view, visit https://asterix-gerrit.ics.uci.edu/1432 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
