Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3386 )
Change subject: [ASTERIXDB-2597] Load UDFs via HTTP ...................................................................... Patch Set 13: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/3386/10/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/10/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java@88 PS10, Line 88: try { > are you sure this does the right thing? The temp directory should be the th Good point, wasn't aware of the 3 argument constructor. https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java@56 PS12, Line 56: public static final String UDF_TMP_DIR_PREFIX = "udf_temp"; > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java@57 PS12, Line 57: public static final int UDF_RESPONSE_TIMEOUT = 5000; > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java@96 PS12, Line 96: ByteBuf reqContent = req.content(); > can we wrap this in a try w/ resources, then you can remove the fc.close() Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/UdfApiServlet.java@153 PS12, Line 153: String reso > oh, i see this is done above- can we set it here so that we set the statuse Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java@404 PS12, Line 404: StringBuilder logMesg = new StringBuilder("Classpath for library " + dataverse + "\n"); : for (URL url : urls) { : logMesg.append(url.getFile() + ", "); : } : LOGGER.info(logMesg.toString()); > multi line log entries complicates log post-processing, can we just create Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/LoadUdfMessage.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/LoadUdfMessage.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/LoadUdfMessage.java@59 PS12, Line 59: } catch (Exception f) { > +1 woops, e,f, they're all the same.... https://asterix-gerrit.ics.uci.edu/#/c/3386/10/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/10/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java@167 PS10, Line 167: ExecutionTestUtil.tearDown(cleanupOnStop, runHDFS); > minor. remove commented out code. Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/library/ILibraryManager.java@33 PS12, Line 33: @ > rm Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java@410 PS12, Line 410: public boolean isExtractFromArchive() { > isExtract* Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/deployment/DeploymentUtils.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/deployment/DeploymentUtils.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/deployment/DeploymentUtils.java@109 PS12, Line 109: if (extractFromArchive) { : downloadURLs(urls, deploymentDir, isNC, true); > +1 Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/deployment/DeploymentUtils.java@252 PS12, Line 252: throw e; > File.delete() doesn't throw IOException if deletion fails, it returns 'fals Done https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java: https://asterix-gerrit.ics.uci.edu/#/c/3386/12/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java@1202 PS12, Line 1202: public boolean isExtractFromArchive() { > isExtract* Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3386 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be9fef54c010bdb32f5c78af9b973f9843f442f Gerrit-Change-Number: 3386 Gerrit-PatchSet: 13 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose (1000171) Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Thu, 27 Jun 2019 22:26:06 +0000 Gerrit-HasComments: Yes
