[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16889246#comment-16889246
 ] 

ASF subversion and git services commented on ASTERIXDB-2614:
------------------------------------------------------------

Commit 655e189f2c81afe41e3b16da3e26a24627a8bef5 in asterixdb's branch 
refs/heads/master from Hussain Towaileb
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=655e189 ]

[ASTERIXDB-2614][TEST] Make type computer test argument count aware

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Obtained the number of arguments from each function's arity to
  know how many arguments to pass for each type computer instead
  of constantly passing only 2 arguments.
- Limited the number of arguments to be passed in case of VARARGS
  or functions with arguments more than 3, this could lead to the
  test taking too long and timing out and failing.

Change-Id: I7188d92101990a6b232c0915f127fbfbf3f6f841
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3500
Sonar-Qube: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hussai...@gmail.com>
Reviewed-by: Ali Alsuliman <ali.al.solai...@gmail.com>


> Make TypeComputer tests argument count aware
> --------------------------------------------
>
>                 Key: ASTERIXDB-2614
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2614
>             Project: Apache AsterixDB
>          Issue Type: Task
>          Components: TEST - Test Framework
>    Affects Versions: 0.9.4
>            Reporter: Hussain Towaileb
>            Assignee: Hussain Towaileb
>            Priority: Major
>             Fix For: 0.9.5
>
>
> Currently, the test passes 2 arguments to test all type computers. For type 
> computers that expect more than 2 arguments, the test might not do a full 
> coverage, and in some cases, it exits directly (not meeting minimum 
> requirements).
>  
> This needs to change to ensure a full coverage of all type computer tests.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to