>From Dmitry Lychagin <[email protected]>: Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4243 )
Change subject: [ASTERIXDB-2680][FUN] Add support to regexp_matches() and regexp_split() ...................................................................... Patch Set 4: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4243/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpMatchesDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpMatchesDescriptor.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4243/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/StringRegExpMatchesDescriptor.java@68 PS4, Line 68: new AOrderedListType(BuiltinType.ASTRING, BuiltinType.ASTRING.getTypeName()); minor. don't use BuiltinType.ASTRING.getTypeName() here, just pass 'null'. We can fix it your next change. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4243 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Iccf5ba14f5c8b8cf4bcd6dd6e412bb515d68dd74 Gerrit-Change-Number: 4243 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2019 18:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
