Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ......................................................................
Patch Set 45: (8 comments) Still more comments... https://asterix-gerrit.ics.uci.edu/#/c/1076/45/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java: Line 51: SequentialFirstRuleCheckFixpointRuleController seqFirstRuleGateKeeperDfs = new SequentialFirstRuleCheckFixpointRuleController( > MAJOR SonarQube violation: You need to apply the updated format file to avoid this violation: https://cwiki.apache.org/confluence/download/attachments/61322291/AsterixCodeFormatProfile.xml https://asterix-gerrit.ics.uci.edu/#/c/1076/45/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 84: private static final int STAGE_1_OUTER_INDEX = 3; Can we also define 2 as a certain name to understand the index? here? Line 177: // Fuzzy similarity function extraction --> Extracts the expressions from the given function. Line 182: // left and right expressions are variables // left and right expressions are variables ---> // left and right expressions should be variables Line 281: // Refer to fj-dblp-csx-hybrid.aql in the optTests for example. optTests -> optimized tests Line 334: // the shared token to the actually tuples of both side. left(right)InputPKs is used to extract those mappings actually -> actual, tuples of both side -> tuples of the both side Line 433: throw new CompilationException(ErrorCode.COMPILATION_TANSLATION_ERROR, e.getMessage()); COMPILATION_TANSLATION_ERROR -> COMPILATION_TRANSLATION_ERROR https://asterix-gerrit.ics.uci.edu/#/c/1076/45/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java: Line 258: @Override Does "hasRun" should be removed even after having the new rule controller? -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 45 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
