[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160826#comment-17160826
 ] 

ASF subversion and git services commented on ASTERIXDB-2754:
------------------------------------------------------------

Commit 26e411e19e5d44146187471c02953de147cfcdb7 in asterixdb's branch 
refs/heads/master from Dmitry Lychagin
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=26e411e ]

[ASTERIXDB-2754][COMP] LoadRecordFieldsRule must clone expression

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- LoadRecordFieldsRule replaces a field access expression with
  another expression that it gets from a record constructor that
  created this field. It must clone the replacement expression
  because it's still used by the record constructor

Change-Id: I4ba653bbb82a76783b295c3bc3cfbed897a3b4e6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/7064
Integration-Tests: Jenkins <[email protected]>
Tested-by: Jenkins <[email protected]>
Reviewed-by: Dmitry Lychagin <[email protected]>
Reviewed-by: Ali Alsuliman <[email protected]>


> LoadRecordFieldRule produces inconsistent query plan
> ----------------------------------------------------
>
>                 Key: ASTERIXDB-2754
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2754
>             Project: Apache AsterixDB
>          Issue Type: Bug
>          Components: COMP - Compiler
>    Affects Versions: 0.9.4
>            Reporter: Dmitry Lychagin
>            Assignee: Dmitry Lychagin
>            Priority: Major
>
> LoadRecordFieldsRule replaces a field access expression with an expression 
> this field was assigned to by a record constructor. The problem is that it 
> does not clone the replacement expression which makes the query plan 
> inconsistent because  the same expression is now shared by two operators.
> See
> [https://github.com/apache/asterixdb/blob/release-0.9.4.1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java#L295]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to