[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17162323#comment-17162323
 ] 

ASF subversion and git services commented on ASTERIXDB-2685:
------------------------------------------------------------

Commit 72abd30a585da23e007b4d22daa712eb751b426e in asterixdb's branch 
refs/heads/master from Hussain Towaileb
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=72abd30 ]

[ASTERIXDB-2685][FUN] regex-split avoid creating unnecessary objects if not 
needed

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Switched to using the RegExpMatcher class to avoid creating
  unnecessary objects (compiling patterns) if the next tuple
  pattern is similar to the previous one.

Change-Id: Ie6920fb049f7b333e3d41de154839d83b5280926
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/7223
Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Reviewed-by: Hussain Towaileb <hussai...@gmail.com>
Reviewed-by: Dmitry Lychagin <dmitry.lycha...@couchbase.com>


> Regexp_split implement inside RegExpMatcher class
> -------------------------------------------------
>
>                 Key: ASTERIXDB-2685
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2685
>             Project: Apache AsterixDB
>          Issue Type: Task
>            Reporter: Hussain Towaileb
>            Assignee: Hussain Towaileb
>            Priority: Major
>
> Currently, the regex_split function is using the Java String.split behavior, 
> which compiles the regex with each call, creating an extra object. This could 
> be done inside our RegExpMatcher which re-uses the existing regex part if 
> it's the same, avoiding the creation of a new object sometimes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to