>From Ian Maxon <[email protected]>: Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 )
Change subject: [ASTERIXDB-2838][RT][FUN] Batched PyUDF calls ...................................................................... Patch Set 6: (9 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-app/src/main/resources/entrypoint.py File asterixdb/asterix-app/src/main/resources/entrypoint.py: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-app/src/main/resources/entrypoint.py@229 PS5, Line 229: FRAMESZ allocate in class https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@149 PS5, Line 149: warn( shouldWarn https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@159 PS5, Line 159: tRef = new FrameTupleReference(); : VoidPointable ref = VoidPointable.FACTORY.createPointable(); put into class https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@173 PS5, Line 173: argHolders.get(func).put(ARRAY32); array16 https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@176 PS5, Line 176: for (int colIdx = 0; colIdx < cols.length; colIdx++) { make setArgument peek for non-nullCall fn's https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@194 PS5, Line 194: , AtomicLong use Counter https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@206 PS5, Line 206: .warn(Warning shouldWarn https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@231 PS5, Line 231: outputWrapper.put(ATypeTag.SERIALIZED_MISSING_TYPE_TAG); emit NULL not missing https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187/5/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalAssignBatchRuntimeFactory.java@248 PS5, Line 248: Exception e make IOException... etc -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/10187 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I5af4da999985afcc33cdfacea79576f1d6109173 Gerrit-Change-Number: 10187 Gerrit-PatchSet: 6 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 02 Mar 2021 03:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
